The shorts look fab on you ella..you definitely do not have dumpy legs, but I know what you mean as I sometimes think shorts don't suit me either.
I think the saltwater look nice, as do the flip flops.
I do sometimes think my SW's make my legs look a bit on the dumpy side if wearing something short, but I think yours with the shorts look good.
I got my new pair of tan SW's last week too and have been wearing them loads.