I'm in Liverpool and we went to Castles in Wales, regularly, as children and Adults, you can get a bit 'Castled out'.
I found Edinburgh Castle, impressive, so did my older teens.
It, is, as it more or less as it was, when it was a thriving Community, with the personal living Quartres of the King and Queen. The Military 'Prison' etc.
We got beautiful Cashmere Scarves, in the Woolen Mill, by the Castle.
Edinburgh, is a fantastic city, you'll have a fabulous time.
The Castle is indoors, so if a day of rain is expected, time it then. We bought the 'Hop on' bus tickets, to see the whole city.