Is it ever ok to turn your jeans trousers into shorts?

[Dorange]

If it is, what is the best, DIY or a tailor?
How do I found out what is the best length for my height? (I am 157cm tall - 5ft2) I think. Probably 56 kg - 8 stones something.
My legs aren't stick thin.

Depends on the look/length you are after. If you want short-shorts, make sure they'll be wide enough at the thigh - skinny jeans probably won't be. If you want longer, skinnies will probably do.

Best bet is to lay them against a pair of shorts you already have that is the fit you want.

If you want frayed denim shorts just cut them to the desired length and put through the wash.

Turn-ups are easy to do. Cut an inch or so too long and use hemming tape (probably has a proper name) to turn up. May also want a few stitches to hold in place.

You can do a proper hem by zig-zag sewing the edge to stop it fraying, turning under, then go over with a thead that matches the jean's original contrast colour.

I've done all these. Usually works well.

I read somewhere once that the most flattering length of shorts is to end them at the thinnest part of your thighs.

Cut much longer than you think you need to, then try them on. It is so easy to make them too short!

You have to be careful otherwise the backs end up a different length to the front

My best and most comfortable pair of shorts began their life many years ago as a pair of skinnies from river Island!

A very large and very sharp pair of scissors lop em off longer than you desire and then turn up. Hey Presto. shorts.