You’re not a shit parent, you’ve got a preschooler and a 3 month old baby, and your DH is undermining something quite fundamental: all of that is HARD, as is sleep deprivation.
FWIW I had my 3yo in nursery 4 days a week while I was on maternity leave, as that was her routine anyway. The day I had the pair of them home, I HATED it. She’s also fussy!
I wouldn’t provide a snack at night as that sets a precedent, but I do sometimes still offer a cup of warm milk to DD if she wakes and says she’s hungry: it’s rare this happens, and when it does, it settles her.
You can’t change DH but you can change you. Clear the house of ice cream, biscuits, etc. Make sure there’s filling stuff available for DS like Greek yoghurt, porridge, peanut butter toast. If DH whinges or restocks his junk, at least put it all in one place out of sight of DS. Hold firm even when you’re exhausted.
After we moved house, moving cities and nurseries, and had a baby, DD went through a phase of only eating ham sandwiches, from inside a cardboard moving box. She called it her quiet box. Two months of ham sandwiches at home, and a vitamin pill; varied diet at nursery. We let her, while always offering a varied diet. Food can easily turn into a battleground, and it’s the one area of their lives they can control. I don’t think your DS is saying “take me out of nursery”, I think he’s saying “help, why is there a baby and why is mummy tired and why sometimes yes ice cream from daddy and sometimes no and the rules are different”. Nursery sets boundaries. At home, he’s got nothing, so he’s putting the control in place by saying “fine, I won’t eat”.
If it helps, I ate nothing but jammy toast til I was about 10, then later on as an adult got a job as a food writer. I don’t have scurvy or rickets; DS will be fine.