Am I being to much?
Not at all - in fact I reckon you are being 'not enough' ...
He is constantly pinching at my daughters snacks, not half the snack or a bite, he will take the whole thing and if he cant get to it he will cry and kick off and I feel I have to pass on some of my child's snacks/food to him as I feel my friend gives me this guilt trip look that im depriving her child of food.
Why are you prioritising the feeling you imagine your friend is projecting at you over your child's need to eat her food?
My friends child has had numerous chocking incidents because he gorges on food, and I get so worried that he will choke on something he has pinched off my childs plate and it will be my fault.
So stop allowing him to pinch your child's food.
Im not silly and I know my child is no angel and will try anything to get out of eating but it is really important she does.
My friend knows my child's health conditions and I have explained this to them on a number of occasions but I feel like its not sinking in.
Because your daughter is not her child, & it's not her responsibility to understand her health conditions.
It would be great if she was able to, & also able to teach/discipline her own child about not pinching food from yours - but the fact is, she doesn't, & it's up to YOU, not HER, to ensure your child's needs are met.
She is never stopping her child from taking off my childs plate and I have found I am recently trying to find excuses to not see them.
Sounds like a good outcome. Friends who choose not to hear you, & who undermine your parenting by actively not hearing that their child's behaviour is affecting your child's wellbeing, are not worth investing much time in.
I feel so so so awful but its frustrating as I feel like its not my place to tell him off
Sure it is. You're an adult - he's a kid who still needs help in understanding what he is doing is wrong.
It's also very much "your place" to protect your DD's wellbeing - AND to teach her, right now at this early age - that you have her back & won't allow boys to take food from her, or bully her in any other way.
but they know the situation and we have discussed it, I also drop hints when the kids are eating in the hope they will understand but its to no avail.
Stop hinting. Start telling.
"Johnny, you know it's not right to take Sally's food" - & when that doesn't work
(it won't, because his mother isn't reinforcing it - so you are saying this for her ears really, not Johnny's) ... PHYSICALLY BLOCK HIS ACCESS TO YOUR DAUGHTER's PLATE.