Uniform. DP is a firefighter and the uniform makes me swoon. Especially when he comes home a bit sooty and smelling of fire.
Dark hair or ginger (I don't find blonde attractive).
Confidence that doesn't spill over into arrogance/cockiness.
Kindness and compassion. Treats others (and animals) well. Says a lot about someone.
Competence. DP just knows how to fit/fix things. Recent examples - services my car, fitted our kitchen, changed the locks, re-hung a door.
Deep voice. Quite like a Scottish accent too. Geordie/Scouse are a complete turn off.