My boy is 3 and he's still waking once to twice a night for a drink.
My DD was the same.
She stopped when she started school.
I could be a crap parent, but then maybe I just have children who wake in the night - same way I do.
All this self-settling bollocks spouted by the HV and cohorts gets right on my tits. Some children don't like self settling and can't be trained to do so.
I'm currently a little bit at a friend's Facebook posts.
Her baby is 6 months old. He slept through from 3 weeks and she brandished it with gay abandon, how perfect he is and how much sleep she's getting.
Bearing in mind it's her 3rd child and her best friend had her 1st baby just a week before her. Her statuses always tagged her friend, so:
Status update:
"Kevin asleep by 6.30 and slept through til 6am. What a good boy. How's Nigel doing? - with Bette Davis"
Bette would reply with "you're such a good mum, Nigel didn't go down til 10 and woke every other hour :( "
I'd read like this 
It took every ounce of restraint not to comment "your baby sleeps because it's how he's wired, it is no reflection on your parenting ability"
6 months on, little Kevin ain't sleeping no more. No gushing status updates, tagging her BFF, just the occasional 3am comment and nod to complete sleep deprivation.