I know they're not asking for career advice, but their switch to "full time celebrity" as their joint post-RF career never made a lot of sense. Maybe for her? But not really for him, and I wonder if he/they were railroaded into it by people hoping to make a LOT of off them (i.e. Netflix etc.).
The only member of the royal family to be "profit-making" is Zara Tindall. She breeds horses/jumps, and has her Longines contract. She lives in a house on her mother's estate and seems to have one of the nicest lives of any royal (speaking as someone who doesn't pay the royals a lot of attention, so I could be massively mistaken!).
She seems to be fairly in control of her life, but I suppose the difference is that she seems to have a positive relationship with her royal parent, unlike Harry, and she was never brought up to be a princess, with all the artificial expectations that brings with it.
That life was fully available to Harry and Meghan, but I think they were misled into believing that it was beneath them and that they could waltz into fame and fortune in America, as a sort of twenty-first century Prince Edward & Wallis Simpson.
A stud farm in England or Argentina raising polo ponies and babies (perhaps with a lifestyle brand built around it), and making regular friendly visits "home" would have been more on brand for him, and conveyed a much more self-assured image than their slightly disjointed appearance these days.