I think the OPs issue with the swimming is more that they haven't actually learned to swim.
I think they do have to ask for money for things because there is no other way of funding trips, activities, shows etc. My daughter's school hasn't been too bad, we are only in our first year there though and only 1 child at school so far.
We have had 2 trips, one was a local free one, a small request twice for 2 different visiting groups to do displays and shows and I think we have had 2 charity days, 1 disco and then PTA activities.
I don't think what WE have been asked for is unreasonable and it has always been clear where the money is going and that it is optional but that they do need a certain amount for trips for them to be viable. the charity things I haven't minded because they have only had a couple of them and again it has been clear that the charity contributions are voluntary.
Children shouldn't suffer if parents can't afford to pay/choose not to pay (as this is the case in some families) but equally I think with many of the trips we do have to share responsibility for them and I think they do the children good to get out of the classroom for a time.
for the OP I would say if swimming lessons are not proving to be effective then you should raise this, if they could make them more effective them perhaps they would only need to be offered for a year which is what our school do. then the money doesn't seem so bad as it is for a shorter time.
regarding charity events speak to the PTA. Is it events to raise PTA money or supporting charities, if it is for supporting charities then perhaps they could consider picking 1 or 2 charities at the start of the year by votes to then support rather than try to support loads of them.