When they talk about tax payers funded for the royal family, you are only looking at one side of profit and loss. It's like saying Ferrari shouldn't make cars as they're too expensive to manufacture without taking into consideration that when someone buys one they make a huge profit. It is impossible to put a figure on how much revenue the royal family generates because it goes into so many places but we definitely a profit from them. Just think of all the money made from coffees sold, flags bought and underground fares paid for the VE day balcony wave alone. That money goes into private business who then pay at tax on their profits which goes back into public funded services, (NHS, education etc).
When the media tells you the royal family are costing you money, it is just goady, scaremongering stuff that makes the stupid and the gullible froth at the mouth, read and click and generate more for the media. Stop falling for it, they don't cost you anything at all.