I don't know. I mean he is paying off debt, fair enough (gambling debt though?) He must have a huge amount of debt if he is still living at his mothers and has no money.
He also doesn't drive. That must be a pita. he gambles (yet has no money and can't afford to move out)
He smokes and drinks (but has no money and can't afford to move out)
Seems his priorities are a little out of whack, no?
If he is living at his mothers, are ALL his wages going on his debt and maintenance? I find that hard to believe.
He comes to yours and eats there twice a week. Does he ever buy the food or offer to cook for you? And then you feel bad about him paying for a taxi back? Why? Hes getting 2 free dinners a week. Also how does he get to yours?
You say he is kind and caring and will do anything for you (except drive, move out of his mothers, pay for stuff, take you out) and hes lucky to have you (he sounds very lucky to have you).
And that hes a kind dad. But you've not met his dc, so you really do not know the situation there or what kind of dad he is. And why is his ex dictating you can't meet the dc if you've been together a year? Are you sure thats the reason op? And if so, if hes serious about you, why isn't he sorting that out?
Obviously don't know him, but he does not seem to be making any effort to be independent. That would really put me off a man, however kind they came across.
Although if you don't want to live with him, but happy with this setup, just carry on. If you want more of a committed relationship/partnership/being a family, then I'm not sure he is sounding like a viable option.