I think there's a compromise to be made between being optimistic and being sensible. WRT money/ property it makes sense that before just putting all your eggs into each others baskets you would discuss how things would work, protect yourself and any DCs future financial security etc its not as simple as first time around, what's mine is yours etc. Your friend is naive and tbh if he would write someone off for wanting to keep some independence he would be no loss to most of us! Self-selection if you like 
I didn't really learn an awful lot after leaving my XH - I ended up quickly falling into a relationship with someone who was his complete opposite, but fucked up in other ways! So basically I'm back to square one now no wiser really.
I know I won't tolerate anything resembling abuse, but it is insidious, it creeps into your life in imperceptible ways (the boiling frog analogy) so I don't know how you guard against that really. I guess just be prepared to leave once you feel uncomfortable, which having some independence helps with.
Being solvent is helpful, but tbh my recent ex had a lot more money than me and it just created an imbalance and made me spend more than I could afford to try and keep up. I would rather someone who wasn't ridiculously wealthy, who can bring more to the relationship than being flash.
Making me laugh is important, sexual chemistry is important, but mainly respect for me and women in general is the main thing I'll be looking for next time. I should have known from the start that XDP's 'chivalry' and 'traditional values' meant he was actually a bit of a sexist dinosaur (despite being younger than me!) I will be listening very closely for anything resembling misogyny with any new partners.
I really have lost hope a bit. I know so many awful men, cheats, narcissists, emotionally stunted man-children, that I do wonder if any of the decent ones could possibly still be single. I'm not looking for now, I need to be happy on my own for a while I think.