I’ve been to Morocco plenty of times mainly because my neighbour is Moroccan and she had plenty of villas and holiday homes which she kindly let us stay at for no charge.
I will try to be as fair as I can with my opinion. As any touristy place scams are common and you really do need to be prepared to say no and mean it and not get scared into paying for anything you are not comfortable with.
I absolutely hated the medina in Marrakech. Full of men who would cat call. Pickpockets in the form of children who distract you. The henna ladies offering to do something for free then saying tip/pay as you like expecting £10/20 for nothing. Never accept a gift. Be prepared to put it down. Don’t take pictures of the monkeys and snakes etc as they expect you to pay. The horse and carriages which take you on a tour of the area looked malnourished to me and I hated that they would whip them to move faster. Broke my heart. Cats are everywhere. I don’t know if they have diseases but I would be careful and lots of kittens everywhere to. They are all over the whole country. As are homeless dogs which roam the street. For some reason Moroccans do not like the dogs and the government have recently been seen to agree euthanise/shoot them which breaks my heart.
i will say however there are some beautiful sights to see. YSL Gardens, the tombs, some beautiful mosques with great architecture. Ouzood waterfalls is a stunning little hike. Atlas Mountains trek is great too. And safari tours.
agadir and essaouira both have beaches with amazing water sports facilities. Fresh seafood. The latter having been the sight of some scenes from Games of thrones.
and tangier and chefchaouen (blue city) are breath taking. There’s so many beautiful places I couldn’t list it all.
I’ve been to turkey and Egypt and both are horrible compared to Morocco.
overall it’s cheap, you get value for money and weather in colder months is still 20-28 degrees which is warmer compared to the uk.
Security in all hotels is impeccable. The staff go out their way to help you. Moroccans are known to be hospitable and will invite you to their homes for dinner and tea with no obligations.
the area where tourists are common also have armed police guards who are there to help tourists and they have also helped us whenever we felt like we were lost or needed saving from a scammer. The locals are scared of police.
never get into a taxi without them running the meter. If they refuse get out and get into another one. They do try to give you a set price but the meter is very cheap. Think a few pounds at most for any journey less than 20 mins.
if there’s anything you’d like to know in more detail let me know il be happy to help.