Edinburgh is great for cultural stuff - theatre, arts.
Glasgow generally better for gigs. Both get good comedy. But Glasgow is only 45 minutes away by train so it's not a hardship.
Great places to walk, beautiful city with lots of green spaces. Bus service is usually fabulous (it's not been great with lockdown but its improving).
Too many tourist tat shops, which have taken over from the small quirky shops I used to love when I came here to visit years ago.
As MightyMurphy said, great restaurants, but some of the places around the royal mile that cater for tourists are mediocre and overpriced.
City centre is awful in August and not quite as bad in December, but still worth avoiding other than when you want to go to the festival etc.
It generally feels safe. It's got a good cycle path network. Weather is typically Scottish, can be beautiful one moment and raining the next.