Could do with some outside perspective because all this is churning round my head like a washing machine. Might be long.
Firstly I should say that DP has always been this way / had these traits but his good points were enough before so I cannot understand why I feel like this now!
Background - We have been together 20 years. I have a DD from previous relationship now at uni and we have a DS together who is 16. We have a baby who is a few months old as well which I should add it was me who wanted her DP said he was too old but in time he changed his mind and agreed he said so I could be fulfilled. I am a bit younger than him but late 30s so felt it was my last chance to experience motherhood as a 'proper adult' I was 18 and 22 last time).
DP has always been moody and he can be snappy and actually quite horrible if things aren't going his way. It's not every day but it is quite frequent. This is to everybody - his parents, his boss, me, even DS (not my DD) although less frequently. I've always gotten over it because I 'knew' he loved me and his upbringing was like this lots of outbursts then couple days silence then everything fine again.
He has always been irresponsible with money. Again probably because he was spoiled as a kid. Grudges paying bills although does pay the bare minimum proportionate to our incomes, but will happily buy presents for everyone take us out etc just doesn't like spending it on 'boring' stuff. Won't save. He is a hard worker when in a job but has left jobs before due to mood swings and arguments with bosses.
He has never been much good with emotional support and can be selfish. I didn't really mind this as he is not terrible for example he will comfort me if something he deems as bad happens, says supportive words, and I do tend to be anxious and a worrier so he is probably weary of me. However our baby is going through tests for a syndrome which carries risks for her health, it's quite serious. This whole time I have been the only one to advocate for her, to spend my savings when waiting lists were too long, and when I first found out he was utterly horrible to me. Could tell he was scared too but he was so cold to me when I was in throws of postpartum and he was working overtime (not for bills for his own stuff). I'm usually quite self sufficient, but he wasn't there.
Some good points are he is lovely when not in a mood, funny, I am attracted to him although this is less recently I don't want near him, faithful as far as I know, he puts up with a health issue I have which means I cannot have sex as often as he'd like, he used to have a drink problem but stopped a few years ago which I do have massive respect for him for and sometimes I think yes it is hard for him.
I don't know what to do. I'm sad and my feelings for him are confusing. Do I love him? If not, then what? He's what I've known for 20 years. Why now when he was the same after DS was born in fact worse?