Gosh, this makes me very defensive. Not all people on the spectrum are the same.
Having said that though, I don't blame someone for thinking 'should I have children with this person' because whoever they are, it's pretty sensible to think it through.
Unfortunately, I am unable to look back and wonder if I did the right thing having children with an diagnosed man on the spectrum because that would be wishing my 2 ASC sons away and everyone knows the reality changes when they're here, flesh and blood walking around with your heart in their hands.
My husband, like your partner, is extremely dependable financially. We will NEVER get into trouble and I know we'll have great pensions etc. We won't however, get new curtains until the old ones are rotting away, spend any money on the house if it's purely decorative or get the children new coats if they can physically get the old ones on 🤨 - the list goes on (heck, it's a struggle to get him to agree to putting the heating when it starts to get chillier)
I believe the crux of the problem with many people on the spectrum is need. Their need vs others' needs. They have a list of priorities in their head and more often than not, their need will be at the top (and their need might not make sense to you either!!) Therefore, in my DH's case, him not wanting to spend money comes before our need to be warm. His need for quiet comes before the children having fun (or indeed being upset) etc. This extends to most aspects of out lives. This doesn't mean he doesn't KNOW how to behave though, so sometimes I can point out his unreasonable behaviour and he will concede and change. He has even been doing it himself recently and I'm proud of him for that.
He is a very good father. But he has his defecits, just like I do. I have depression which mean I parent in a less than optimal way sometimes but I'm still essentially a good and loving parent. And who/what is a perfect parent anyway?
If you love each other, who else are you going to have kids with??! If you don't love him, have kids with someone else (or on your own)
One thing I will say though, if you choose to have children with him, it's more than likely your children will be on the spectrum and it will be fucking exhausting to be in a neurodiverse family when you're not.
It's desperately hard. And lonely. But they're my family.