We're in a 1939 semi. For us (have lived in new build, 1960s semi, Edwardian terrace) it wasn't so much the style of the house - think elderly lady style, family had owned it for 50 years - but the potential. Usually, decent sized plot (decent sized front & back garden), option to extend across drive at side & rear, lovely cul-de-sac location, perfect in terms of location. It did come with gorgeous stained glass bay windows, picture rails (as well as the floral carpets everywhere, including loo and bathroom!).
We lived in it for a couple of years doing the absolute bare minimum because we couldn't afford to - replaced tiled worktop -with grout that had gone black on Day 1, ripped up carpets. The 60s peach bathroom suite and textured wallpaper were particular highlights but couldn't afford to change those!!
Then a couple of years later we knocked down wall between kitchen & dining room which made a massive difference, had cupboards built either side of the fireplace etc. Started to look nice.
We've been here 8 years now, 2 years ago had a big extension to add more space downstairs, plus get a 4th bedroom and ensuite. It's not cheap though as a pp said, we didn't go high end and it's cost about £100k (North West) - that's not including the garden work / drive which we still have to do. Having said that, we simply would not have been able to buy a 4 bed house for the cost of the house + extension, so we were buying the "potential". We love it, our neighbours are all similar - families or older couples whose children have left home and there's a real sense of community.
Just one point - be careful to check out each house. Even though they're all lumped together as 1930s houses, the styles are often dlightly different. Some are bigger than others, some have narrower driveways. Ours, for instance, doesn't have the head height in the loft for a standard loft conversion, we would have had to lower the upstairs ceilings. Conversely our "box" room is actually a small double (at 9ft x 9ft).