Do what works for YOU. Are you happy feeding to sleep, or not? I fed my DD to sleep until she was 2. It worked for me. When I wanted to change it, I did. We didn’t ever do any sleep training or have any tears, because I didn’t fancy it. If it isn’t working for you, then there are plenty of things you could try.
Feeding to sleep does NOT mean your child with always be dependent on you. Firstly, they do grow out of it, or can be gently encouraged when you want to. But damn, is it effective when they are tiny! Secondly, even babies can learn that different situations mean different actions. My DD was perfectly happy to nap in the pram for my mum when I went back to work, or on my DHs chest (his preferred method! He loved a good long cuddle and an excuse to watch telly) of a weekend. When she started nursery, her keyworker held her for her nap on the first day, but on the second she just lay down on a mat like all the other toddlers and went straight to sleep. My MIL sang her to sleep at bedtime once. Just because they do things one way for you, it does NOT mean that you will be the only person that can ever settle them, just that you have the ultimate weapon in your arsenal - I could feed my DD to sleep ANYWHERE (in the middle of a field during a cricket tournament, on a sofa at a loud wedding reception, at someone else’s house while I chatted to a friend, at a cafe, at church.....). Because it is a strong sleep association, you don’t need any others, so providing you are comfortable feeding in public, you aren’t constrained to being at home with their cot in a darkened, quiet room.
Feeding them to sleep does not form permanent associations that are impossible to shift, and it does NOT mean your child will never learn to self settle. My DD is 3 now (so much older than yours), and I kiss her goodnight wide awake, switch on her nightlight and walk out of her room. She’s generally dead to the world within 10 mins, and when she’s not, she chats to her dolls until she’s ready for sleep. She only wakes up if she has a nightmare, otherwise she’s out cold till at least 7am.
If you’re happy, stick with it and don’t worry that it’s going to become a problem. You can change it whenever you want to, and it’s easier when they are older and can understand better. As soon as you feel it’s not working for you, make a change.
P.s. currently pregnant with twins and planning on feeding them to sleep if the logistics works!