We went to NY in February this year and it was our best family holiday ever! We had booked a year ago, with the optimism that Trump would not be reelected, so we were wary about that politically and ethically, but it did not mar our holiday in any way. All of the New Yorkers we met were liberal and fiercely anti-Trump.
We took clothes for artic conditions, but it was relatively mild, light winds and sunny. Jeans and rab jackets sufficient.
There was so much to see and do and the atmosphere /vibe was incredible. We did all the tourist stuff you would expect, museums, shops, diners, theatre, ice skating and hours of meandering. It was very pricey but we did push the boat out. We stayed in a large chain hotel near Times Sq, which was more than fine - personally, out of choice, I would stay in a serviced apartment or smaller hotel in East or Greenwich village, and use the take out delis for some cheaper meal options.
oh, and we used the metro day and night with no issues and felt completely safe.
The only trouble is that the teens say they never want to go anywhere else!