There's a load of talk on here about is Edinburgh "posh" - to which I and many others say there is a small, posh crowd (who may also be very nice, people would be flamed for asking if Edin was chavvy) who keep in their own clique and most students don't encounter then except obliquely. The famously posh accommodation is Chancellor's Court within Pollock as it's the most expensive. My own dc (now older) was in Pollock first year and it was great for them in terms of meeting other students and being catered, right under Arthur's Seat, which was pretty spectacular - they couldn't cook, but those who can cook may want to be in self-catered, there are plenty of options.
Apart from that, my dc is having a blast and for third year is off to a pretty amazing university abroad as are many of their friends, Edin has good links internationally including with Ivy League universities.
They have a two semester structure, so a long autumn term and spring term and then break up very early (in most cases, it varies according to courses) for summer so there's a long summer break, which is great for work/internships/travel - dc earned some decent money and then spent it on having the equivalent of a gap year travelling in S America in their first summer break.
Travel there is not the huge issue some people seem to make out, trains are regular and fast - we used a shipping service to send up dc's stuff at the beginning and end of the year so we've never driven there. It was very reasonably priced. Buses in Scotland are free for under-26 - that's to go everywhere in Scotland so you can explore, also free dentists and hygienists, plus there's never any issue about things like getting a GP's appointment.
It's THE most beautiful city, there's loads going on, and I'm sure your dd will love it as much as my dc - and other family members have done.