I love Jane's Patisserie, I discovered her on Instagram. Somehow all of her recipes seem to work for me.
www.janespatisserie.com
She wrote recently that you should weigh your eggs in their shells, and then use equal weights of sugar, self raising flour, butter/stork. So if your eggs are 178g for example, then use 178g of flour, 178g sugar, etc. Add a splash of milk if the mix looks too thick.
I personally prefer to cream butter and sugar together first (for longer than you think) until really creamy and pale, add gently beaten eggs slowly, bit by bit,, then sieve in the flour and gently fold. I get a nicer texture this way. Don't over mix.
As others have said, the size of tin helps. Always use a very deep tin and line it well - shallow tins seem to produce flatter cakes for me.
Lower temps for longer make a flatter top (I.e. not a domed cake) but give a nice rise and good texture. More like 140-160 degrees, ish. Get an oven thermometer. Don't slam the oven door or keep opening it to check progress.
The fresher the eggs, the better, too. We have lots of fresh roadside eggs around where I live, they produce really yellow and rich cakes!
Make sure the butter and eggs are at room temperature before you start.
I'm happy with butter, but lots of people do say that stork spread or similar make better cakes.
But as others have said, if people are requesting the cakes, they're probably really good!