Like NoKnit, I feel you may be conflating two questions here. The one being how do you bring your children up to behave as you would like, the other how do you guarantee that they get the financial outcome they would like in life. You may find that there is a certain element of luck to both of them, but more so to the second.
My 19yo ds is not as far as I can make out academically gifted or outstandingly clever with his hands. He also suffers from crippling anxiety, which would make any entrepreneurial activities almost impossible for him. Given this situation, it is likely that he will have to adapt his expectations of lifestyle to what is realistically achievable.
But he is the young man who ran out of the house in the middle of the night at the weekend because he heard the cry of a woman in distress and thought someone might have been attacked. And ds is quite streetwise enough to understand the risk he would be taking if there was a man waiting out there with a knife.
Do you think I feel I have failed at bringing him up because he probably won't be able to dictate terms to a future employer and choose the lifestyle he would want to have? Do you think there is some other way he could be that would make me more proud of him?
There is no discipline that could conceivably have made it easier for him to learn to read and write or to shine at maths (has attempted and failed GCSE maths 3 times, currently waiting for results from 4th attempt). That was not in my gift.
Possibly his decency is innate, too. Or perhaps that is where dh and I have been able to play a part: by giving a reasonably good example, by making sure he would never get away with being mean or nasty either to anybody else or to us, by making sure that he knows that these are our expectations, by making him feel loved, by letting him know that we believe he is a good person. And for the discipline basically doing what pikapikachu said.
Dd (22) is perhaps more conventionally clever. But she has become physically disabled (wasn't apparent when she was born) and has MH issues. Happiness is not in our gift. The best we have been able to do for her has been to support her in dealing with the hand she has been given and by making sure she knows it is never right to take out your unhappiness on other people. Again, lifestyle success will have to work around what is achievable.
So, to address your second question: we have very much focused on kindness and honesty. Have tolerated a certain amount of backchat, but never rudeness. Have tried to model calm and self control. Have explained that sometimes you are allowed to think rules are silly or that a person in authority is wrong, but that you still have to obey rules and be polite. Tried not to be unnecessarily confrontational but never given in to demands to keep the peace. Letting them know at 2 that they won't get the sweeties because they are screaming makes it easier to stand firm when they are 14 and want you to buy that bottle of scrumpy to stop them from getting the vodka off a mate.