This feels like a thread that could offend some people, but here goes......
I would never buy a terraced house. Potential of noise from both sides.. And they never seem to have a front garden/are almost always 6 feet from the road,
Although...... The ones that were built pre 1930s are very solid and well built, and some people I know live in them, in Shrewsbury, Chester, and London, and Colchester, and they have been there several decades, and many of them have always been happy. They say they rarely hear the neighbours, and the back gardens are big/long (like 150 feet,) and they love the Victorian feel to their home. Many have cellars too.
A friend of mine bought a terraced house in Shrewsbury in 2012, (2 bedroom house, and quite small.) with a view to moving after 5 years and when they had a baby. But they love it so much - lovely town, everything they need, not far from train station, close to Welsh border, but not far from other big towns, and lovely neighbours, so they have stayed put. I would still not move into one though LOL.
I would never buy a flat either. Not being snobby, I would live in one, but wouldn't buy.....
Anything open plan.... No. For all the reasons listed by others.
A dormer style house (like on this pic.) Pretty, but tiny poky bedrooms that you can barely fit furniture in. Especially wardrobes! Also, the big roof causes endless maintenance issues! (And they often get birds/birds nests, and bats in them.)