positrans
Your paper is a cross-sectional survey relying on self-recall. Such a design scores pretty low on the evidence hierarchy.
It asked 20619 transgender adults aged 18-36 years to fill in a survey.
It asked them to recall if they ever wanted puberty blockers? Yes = 16.9%
Of that group did they receive them? Yes = 2.5%
It also asks them to assess their suicidality.
It compares lifetime suicidal ideation in the 2.5% that recalls they wanted puberty blockers and received them, to the group that recalls they wanted puberty blockers and didn't receive them. It expresses the result as an odds ratio, a statistical way to express the result that is particularly difficult to understand. However a statistically significant difference is shown, for this retrospective cross-sectional survey.
This is not an evidence base for giving puberty blockers.
This shows that young adults who recall they wanted to receive PBs who went on to receive them have a lower odds ratio of suicidality during their young adult life than young adults who recall they wanted to receive PBs who didn't go on to receive them.
Gold standard evidence would be prospective and randomised.
Take a group of children who have been referred for assessment to GIDS (or wherever)
Randomise half of them to puberty blockers, and half to another treatment (watchful waiting? psychological support?)
Follow them up for suicidal ideation, regret, move to cross sex hormones, surgery, psychological outcomes etc. I'd suggest a long follow up (5-10 years) based on the timecourse of regret seen with detransitioners.
Then hopefully we can stop arguing and implement some proper evidence-based management of these children.