We don't really like them eating chocolate because of their teeth, so we always make a big deal how they can have an egg or we can donate double the amount an egg costs to charity. We go for child friendly charities, my DC know about Water Aid, plus charities that help child in Syria, other countries where what we take for granted isn't the norm. I saw a few shops with Eggs for £1, they don't need a big egg really.
It's not everyone's cup of tea, as I'm religious, although faith doesn't have to come into it, Easter is a time before during Lent, giving up things for the purpose of acknowledging there's those who go without. So that's how we bring charity into it.
We don't give something up, we just have a day on Fridays, where we fast, the children are encouraged not to eat meat and to think about children who don't have choices when it comes to food. They eat what they're given.
Usually both DC would have quite a few eggs from elderly friends and neighbours, but most have died in the last year. They're not big on chocolate anyway. I don't think there's a right or wrong answer, most of us are winging this parenting thing. With DH it's about having teeth that are nice as we knew one poor child who had to go to hospital for baby teeth extraction they were that rotten. They would have fizzy pop, sweets, chocolate etc.
I'd say it's entirely your choice.